Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FTheoryTools] More on Chern classes and topological invariants #3979

Merged
merged 4 commits into from
Aug 29, 2024
Merged

[FTheoryTools] More on Chern classes and topological invariants #3979

merged 4 commits into from
Aug 29, 2024

Conversation

HereAround
Copy link
Member

@HereAround HereAround commented Jul 28, 2024 •
edited
Loading

@HereAround HereAround marked this pull request as draft July 28, 2024 16:02
@codecov Codecov
Copy link

codecov bot commented Jul 30, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 95.16129% with 3 lines in your changes missing coverage. Please review.

Project coverage is 84.63%. Comparing base (5edd2b0) to head (da292a7).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
...heoryTools/src/AbstractFTheoryModels/attributes.jl 94.28% 2 Missing ⚠️
...heoryTools/src/AbstractFTheoryModels/properties.jl 95.65% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3979      +/-   ##
==========================================
+ Coverage   84.62%   84.63%   +0.01%     
==========================================
  Files         600      600              
  Lines       82590    82609      +19     
==========================================
+ Hits        69894    69920      +26     
+ Misses      12696    12689       -7
Files with missing lines Coverage Δ
...perimental/FTheoryTools/src/G4Fluxes/properties.jl 100.00% <100.00%> (+9.52%) ⬆️
...rimental/FTheoryTools/src/TateModels/attributes.jl 86.58% <100.00%> (+0.16%) ⬆️
...l/FTheoryTools/src/WeierstrassModels/attributes.jl 86.53% <100.00%> (+0.26%) ⬆️
...heoryTools/src/AbstractFTheoryModels/properties.jl 98.33% <95.65%> (-1.67%) ⬇️
...heoryTools/src/AbstractFTheoryModels/attributes.jl 97.99% <94.28%> (+1.60%) ⬆️

... and 1 file with indirect coverage changes

lgoettgens
lgoettgens reviewed Jul 31, 2024
View reviewed changes
Copy link
Member

@lgoettgens lgoettgens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #3985 for the reason of the proposed changes

experimental/FTheoryTools/src/AbstractFTheoryModels/attributes.jl Outdated Show resolved Hide resolved
experimental/FTheoryTools/src/AbstractFTheoryModels/attributes.jl Outdated Show resolved Hide resolved
experimental/FTheoryTools/src/AbstractFTheoryModels/attributes.jl Outdated Show resolved Hide resolved
experimental/FTheoryTools/src/AbstractFTheoryModels/properties.jl Outdated Show resolved Hide resolved
@HereAround
Copy link
Member Author

HereAround commented Aug 1, 2024 •
edited
Loading

Thank you @lgoettgens for pointing this out. Since I care about the history of this PR (do not want the changes squashed), I will rebase and add the suggested change.

UPDATE: Just fixed, and rebase to the master branch.

@HereAround HereAround force-pushed the MoreChernClasses branch 5 times, most recently from 5c08683 to 763ac32 Compare August 6, 2024 15:30
@HereAround
Copy link
Member Author

I have refactored and worked-over this PR. In particular, this requires the Chern classes of (the tangent bundle of) toric varieties, which begs for a separate PR. This separate PR is open here #3996 and should be discussed/merged first. For my convenience, I have included the current state of this other PR here.

@HereAround HereAround force-pushed the MoreChernClasses branch 2 times, most recently from 962b88b to 3a42f0a Compare August 9, 2024 15:02
@HereAround HereAround force-pushed the MoreChernClasses branch 10 times, most recently from 4e5cd40 to 66acaf5 Compare August 22, 2024 15:09
@emikelsons emikelsons mentioned this pull request Aug 26, 2024
Merged
@HereAround HereAround marked this pull request as ready for review August 28, 2024 13:32
@HereAround HereAround added the enhancement New feature or request label Aug 28, 2024
emikelsons
emikelsons approved these changes Aug 29, 2024
View reviewed changes
Copy link
Collaborator

@emikelsons emikelsons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and most of the tests pass. At this point this has already been tested quite extensively as well.

@HereAround HereAround merged commit 869b9ba into oscar-system:master Aug 29, 2024
28 checks passed
@HereAround HereAround deleted the MoreChernClasses branch August 29, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lgoettgens lgoettgens lgoettgens left review comments

@benlorenz benlorenz benlorenz left review comments

@fingolfin fingolfin fingolfin left review comments

@emikelsons emikelsons emikelsons approved these changes

@apturner apturner Awaiting requested review from apturner

Assignees
No one assigned
Labels
enhancement New feature or request topic: FTheoryTools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@HereAround @fingolfin @benlorenz @lgoettgens @emikelsons